[DataGrid] Fix toggling preference panel from toolbar (@lauri865) (#1…

…6276) Co-authored-by: Lauri <[email protected]>
mui · Jan 21, 2025 · 95dc368 · 95dc368
1 parent 093cf6a
commit 95dc368
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/packages/x-data-grid/src/components/panel/GridPanel.tsx b/packages/x-data-grid/src/components/panel/GridPanel.tsx
@@ -125,7 +125,7 @@ const GridPanel = forwardRef<HTMLDivElement, GridPanelProps>((props, ref) => {
       {...other}
       ref={ref}
     >
-      <ClickAwayListener mouseEvent="onMouseUp" onClickAway={handleClickAway}>
+      <ClickAwayListener mouseEvent="onPointerUp" touchEvent={false} onClickAway={handleClickAway}>
         <GridPaperRoot
           className={classes.paper}
           ownerState={rootProps}

diff --git a/packages/x-data-grid/src/components/toolbar/GridToolbarColumnsButton.tsx b/packages/x-data-grid/src/components/toolbar/GridToolbarColumnsButton.tsx
@@ -70,6 +70,11 @@ const GridToolbarColumnsButton = forwardRef<HTMLButtonElement, GridToolbarColumn
           aria-controls={isOpen ? columnPanelId : undefined}
           startIcon={<rootProps.slots.columnSelectorIcon />}
           onClick={showColumns}
+          onPointerUp={(event) => {
+            if (preferencePanel.open) {
+              event.stopPropagation();
+            }
+          }}
           {...rootProps.slotProps?.baseButton}
           {...buttonProps}
           ref={ref}

diff --git a/packages/x-data-grid/src/components/toolbar/GridToolbarFilterButton.tsx b/packages/x-data-grid/src/components/toolbar/GridToolbarFilterButton.tsx
@@ -159,6 +159,11 @@ const GridToolbarFilterButton = forwardRef<HTMLButtonElement, GridToolbarFilterB
             </rootProps.slots.baseBadge>
           }
           onClick={toggleFilter}
+          onPointerUp={(event) => {
+            if (preferencePanel.open) {
+              event.stopPropagation();
+            }
+          }}
           {...rootProps.slotProps?.baseButton}
           {...buttonProps}
           ref={ref}