-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all apps from KPIs notion page (except 2 Zendesk apps) #89
Conversation
Added ratio
Adding overdue ratio app back in mui-public
Only Zendesk app remains from KPIs
Your Render PR Server URL is https://tools-public-pr-89.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cgdnl7vdvk4pe48v054g. |
value: 0 | ||
unit: | ||
type: const | ||
value: days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe the other way around, we should fix the badge component, yeah probably better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it in the component.
value: 20 | ||
unit: | ||
type: const | ||
value: minutes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that there should be a space here.
value: minutes | |
value: ' minutes' |
It feels obvious on this PR that we need to allow toolpad users to have one file per page. It's already hard to follow what changes what app cc @Janpot |
Agreed, I'm getting to that in mui/toolpad#1831. Still have to tie up a few loose ends, but it's mostly working with integration tests passing. |
Extract from https://master--toolpad.mui.com/_toolpad/app/cl9hns2z30002pr9kzw4dqx76/pages/4003nxy
Preview: https://tools-public-pr-89.onrender.com/prod