Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all apps from KPIs notion page (except 2 Zendesk apps) #89

Merged
merged 8 commits into from
Mar 23, 2023

Conversation

prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Mar 22, 2023

@render
Copy link

render bot commented Mar 22, 2023

@oliviertassinari oliviertassinari changed the title Added all apps from KPIs notion page (except 2 Zendesk apps) Add all apps from KPIs notion page (except 2 Zendesk apps) Mar 22, 2023
value: 0
unit:
type: const
value: days
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that there should be a space here

Suggested change
value: days
value: ' days'

Screenshot 2023-03-22 at 23 32 50

Copy link
Member

@oliviertassinari oliviertassinari Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe the other way around, we should fix the badge component, yeah probably better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it in the component.

value: 20
unit:
type: const
value: minutes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that there should be a space here.

Suggested change
value: minutes
value: ' minutes'

@oliviertassinari
Copy link
Member

It feels obvious on this PR that we need to allow toolpad users to have one file per page. It's already hard to follow what changes what app cc @Janpot

@oliviertassinari oliviertassinari merged commit dc84d30 into master Mar 23, 2023
@oliviertassinari oliviertassinari deleted the more-oss-examples branch March 23, 2023 16:37
@Janpot
Copy link
Member

Janpot commented Apr 1, 2023

It feels obvious on this PR that we need to allow toolpad users to have one file per page. It's already hard to follow what changes what app cc @Janpot

Agreed, I'm getting to that in mui/toolpad#1831. Still have to tie up a few loose ends, but it's mostly working with integration tests passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants