[code-infra] Add command run duration measurement

[brijeshb42]

to each relevant sub-command. And some cleanup.

Removed copy-files command since all repos are now migrated.

Removed markFn and measureFn functions and wrapped their functionality
in a single HOC withPerformanceMeasurement.

[mui-bot]

Bundle size report

Bundle	Parsed size	Gzip size
@base-ui-components/react	0B(0.00%)	0B(0.00%)

Details of bundle changes

[brijeshb42]

Handy to see when comparing the new build tools transpilation times.

[Janpot]

Not a huge fan of this style, it's such an arbitrary way of separating the different commands, and it makes the logic in this file hard to understand.

How do you feel about instead we create a function that we can use to wrap a command handler function and just in each command file that we want this output on we wrap their handler function?

import withCmdMeasure from './withCmdMeasure'

export default {
  command: 'argos-push',
  handler: withCmdMeasure(async (argv) => {
    // ...
  })
}

I suppose in the wrapper we can read the command name from argv._[o].

[brijeshb42]

This would also work. I don't have during opinions here.
This is something I thought of previously.

[Janpot]

I think the way it's currently done is a bit of an anti-pattern.

[Janpot]

Suggested change

	const command = /** @type {import('yargs').CommandModule<{}, Args>} */ ({
	export default /** @type {import('yargs').CommandModule<{}, Args>} */ ({

I really would like to keep this simple and have a function that only wraps the handler, something we can add/remove like a middleware without imposing changes on how these command modules are structured. It's not important enough as a feature to be so visually present in our source code.

[brijeshb42]

The problem with handler: withPerformanceMeasurement(label, async (args) => {}) is that args's type does not get detected automatically the way it is when its just handler: async (args) => {}.

[Janpot]

I believe this should do the trick

// ./types.d.ts
import { CommandModule } from 'yargs';
export type CommandHandler<T> = CommandModule<{}, T>['handler'];
export type HandlerMiddleware = <T>(handler: CommandHandler<T>) => CommandHandler<T>;

// ./myCommand.mjs
/**
 * @type {import('./types').HandlerMiddleware}
 */
function withMiddleware(handler) {
  return async (argv) => {
    await handler(argv);
  };
}

// ...

  handler: withMiddleware(async (argv) => {

[brijeshb42]

I'll pick this up again later. Not happy with the type inference that I've added.

[github-actions]

This pull request has been inactive for 30 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 15 days.

[dav-is]

Why clear the marks? Isn't it helpful when profiling?

[brijeshb42]

lastMeasurement already gets the measured value. So clearing after usage. These scripts are not really meant to be profiled to be studied for tiny perf improvements. So clearing it.