Skip to content

[autocomplete] Fix helper text focusing input when clicked (@mj12albert) #48162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mj12albert merged 2 commits into from
Apr 1, 2026
Merged

[autocomplete] Fix helper text focusing input when clicked (@mj12albert) #48162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f938684
[autocomplete] Fix helper text focusing input when clicked (#48156)
mj12albert Mar 31, 2026
ec01e63
ci
mj12albert Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/mui-material/src/Autocomplete/Autocomplete.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1322,6 +1322,18 @@ describe('<Autocomplete />', () => {
expect(handleOpen.callCount).to.equal(1);
});

it('should not focus the input when clicking helper text', async () => {
const { user } = render(
<Autocomplete
options={['one']}
renderInput={(params) => <TextField {...params} helperText="Some help" />}
/>,
);

await user.click(screen.getByText('Some help'));
expect(screen.getByRole('combobox')).not.toHaveFocus();
});

it('does not clear the textbox on Escape', () => {
const handleChange = spy();
render(
Expand Down
8 changes: 8 additions & 0 deletions packages/mui-material/src/useAutocomplete/useAutocomplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,6 +1155,10 @@ function useAutocomplete(props) {
if (!event.currentTarget.contains(event.target)) {
return;
}
// Don't interfere with interactions outside the input area (e.g. helper text)
if (anchorEl && !anchorEl.contains(event.target)) {
return;
}
if (event.target.getAttribute('id') !== id) {
event.preventDefault();
}
Expand All @@ -1166,6 +1170,10 @@ function useAutocomplete(props) {
if (!event.currentTarget.contains(event.target)) {
return;
}
// Don't interfere with interactions outside the input area (e.g. helper text)
if (anchorEl && !anchorEl.contains(event.target)) {
return;
}
inputRef.current.focus();

if (
Expand Down
Loading