[test] Use plain playwright for e2e #47410
Merged
+64
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-47410--material-ui.netlify.app/ Bundle size report
|
mj12albert
force-pushed
the
test/e2e-playwright
branch
from
714ee83 to
b8e57a7
Compare
Janpot
reviewed
Dec 5, 2025
| async function renderFixture(fixturePath: string) { | ||
| await page.goto(`${baseUrl}/e2e/${fixturePath}#no-dev`); | ||
| await page.goto(`${BASE_URL}/e2e/${fixturePath}#no-dev`); | ||
| await page.waitForSelector('[data-testid="testcase"]:not([aria-busy="true"])'); |
Member
There was a problem hiding this comment.
fyi: on regression tests we found this to be prone to race conditions as it doesn't check which test case is actually rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: mui/base-ui#2688 (comment)
It's more straightforward to use plain playwright instead of mixing it with testing library