Skip to content

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Sep 10, 2025

closes #46850

@sai6855 sai6855 changed the title React-window [docs][Autocomplete] Update virtualization example to use react-window v2 Sep 10, 2025
@mui-bot
Copy link

mui-bot commented Sep 10, 2025

Netlify deploy preview

https://deploy-preview-46900--material-ui.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 67ce5d3

@sai6855 sai6855 marked this pull request as draft September 10, 2025 11:52
@sai6855
Copy link
Contributor Author

sai6855 commented Sep 11, 2025

@siriwatknp Migration to react-window v2 is extremely painful there is no official migration guide. I went through v2 docs and v1 docs to figure out what all changed.

these are all the resources i could find.

  1. https://react-window.vercel.app/list/props
  2. Version 2.1.0 bvaughn/react-window#836
  3. Version 2 bvaughn/react-window#824

Previews of all demos that effected by version upgrade

Regarding argos failure, I'm not really sure why it's failing. Looking at DOM of both v1 and v2, react-window has removed outerElement support and innerElement support (source), I suspect it is what causing argos issue. I think diff shown in argos is extremly minimal, since it's causing by external library and there is not enough guidance on migrartion, can we approve the change?

@sai6855 sai6855 requested a review from siriwatknp September 11, 2025 18:36
@sai6855 sai6855 marked this pull request as ready for review September 11, 2025 18:36
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 12, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 12, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 12, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 12, 2025
@zannager zannager added docs Improvements or additions to the documentation. scope: autocomplete Changes related to the autocomplete. This includes ComboBox. labels Sep 12, 2025
@zannager zannager requested a review from mj12albert September 12, 2025 08:50
@caspardue
Copy link

I ran into the same issue earlier today before I saw this PR. I ended up at the same solution you did, but I also noticed that keyboard navigation stopped working (as in your example). The lack of migration documentation for react-window makes this especially frustrating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation. scope: autocomplete Changes related to the autocomplete. This includes ComboBox.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Autocomplete Virtualization example not compatible with react-window v2
4 participants