Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lab] Fix TabList type exports #44807

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

barlock
Copy link

@barlock barlock commented Dec 18, 2024

This change exports TabListOwnProps to fix a typescript error when styling the TabList component.

Example:

export const StyledTabList = styled(TabList)({
  height: `min-content`,
  minHeight: `auto`,
  overflow: `visible`,
  [`.${tabsClasses.scroller}`]: {
    height: `fit-content`,
  },
});

Create's the following error:

TS4023: Exported variable `StyledTabList` has or is using name `TabListOwnProps` from external module

Exporting the type fixes the issue.

@mui-bot
Copy link

mui-bot commented Dec 18, 2024

Netlify deploy preview

https://deploy-preview-44807--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 0e5cef7

@zannager zannager added package: lab Specific to @mui/lab component: tabs This is the name of the generic UI component, not the React module! labels Dec 19, 2024
@zannager zannager requested a review from DiegoAndai December 19, 2024 10:41
@aarongarciah
Copy link
Member

Hey @barlock I wasn't able to reproduce the TypeScript error https://codesandbox.io/p/sandbox/wizardly-montalcini-c7k3g7?file=/src/Demo.tsx. May I ask you to provide a reproduction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tabs This is the name of the generic UI component, not the React module! package: lab Specific to @mui/lab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants