[Slider] Set onChangeCommitted to receive the last argument passed to onChange #44795
+89
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-44795--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
mnajdova
added
bug 🐛
good-jinu
force-pushed
the
slider-on-change-on-change-committed
branch
3 times, most recently
from
7e07151 to
ab1e076
Compare
- Add test case for differing values passed to onChange and onChangeCommitted in Slider
- Set onChangeCommitted callback in Slider to receive the last argument passed to onChange
good-jinu
force-pushed
the
slider-on-change-on-change-committed
branch
from
ab1e076 to
51f1489
Compare
github-actions
bot
added
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://codesandbox.io/p/sandbox/nice-ully-k38gjr
The value is determined by the mouse position at the time onChange and onChangeCommitted are called. The discrepancy in the mouse position between the last onChange call and the onChangeCommitted call led to different argument values.
To address this, I've modified onChangeCommitted to always receive the last argument passed to onChange.
Closes #41739