[core-infra] Add no-relative-packages #44489
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
no-relative-packages
branch
from
ce8ccae
to
548208b
Compare
Netlify deploy previewhttps://deploy-preview-44489--material-ui.netlify.app/ Bundle size report |
it mostly is, the main problem I've seen so far is that it stops us from being able to rely on workspace topology to detect changes. e g. to run tests selectively. for things like the vitest config, we could always place those in their own package. |
Janpot
reviewed
Nov 21, 2024
| @@ -4,6 +4,7 @@ import fetch from 'cross-fetch'; | |||
| import fse from 'fs-extra'; | |||
| import * as mui from '@mui/icons-material'; | |||
| import synonyms from 'docs/data/material/components/material-icons/synonyms'; | |||
| // eslint-disable-next-line import/no-relative-packages | |||
| import myDestRewriter from '../../packages/mui-icons-material/renameFilters/material-design-icons'; | |||
There was a problem hiding this comment.
can likely be reorganized to live under this package instead. but low priority.
Janpot
approved these changes
Nov 21, 2024
JCQuintas
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move mui/mui-x#15437 from MUI X to code-infra.
This breaks in Base UI. Some are nice, they show cases where we import private APIs in the
app/experimentssome are weird, e.g. https://github.com/mui/base-ui/blob/d7809157ccc737608acc70a1ecbb42dfbca7ae78/packages/mui-base/vitest.config.ts#L2 seems fine.