Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Use vitest-compatible skip in describeConformance #44412

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

JCQuintas
Copy link
Member

Use this?.skip?.() ?? t?.skip(); so we can continue the vitest migration 😅

@JCQuintas JCQuintas added bug 🐛 Something doesn't work scope: code-infra Specific to the core-infra product labels Nov 14, 2024
@JCQuintas JCQuintas requested review from siriwatknp and a team November 14, 2024 18:06
@JCQuintas JCQuintas self-assigned this Nov 14, 2024
@mui-bot
Copy link

mui-bot commented Nov 14, 2024

Netlify deploy preview

https://deploy-preview-44412--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c9467aa

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👌

@JCQuintas JCQuintas merged commit f2cfee3 into mui:master Nov 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants