[docs][material-ui] Fix Sign-in/Sign-up templates layout #44281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanivan
added
docs
Netlify deploy previewhttps://deploy-preview-44281--material-ui.netlify.app/ Bundle size report |
aarongarciah
approved these changes
Oct 31, 2024
| @@ -228,6 +214,18 @@ export default function SignIn(props: { disableCustomTheme?: boolean }) { | |||
| > | |||
| Sign in with Facebook | |||
| </Button> | |||
| <Typography sx={{ textAlign: 'center' }}> | |||
| Don't have an account?{' '} | |||
| <span> | |||
There was a problem hiding this comment.
No introduced in this PR, but this span is not required.
Yep, will change this one to be |
ananyachandra33
approved these changes
Oct 31, 2024
|
Great thanks, it feels much better. I have unticked item 9 from #42609 per #44281 (review). |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes layout in Sign-in and Sign-up templates according to @oliviertassinari's feedback in item 9 from #42609
👉 https://deploy-preview-44281--material-ui.netlify.app/material-ui/getting-started/templates/sign-in/