[code-infra] Allow overriding all options of useFakeTimers function
#43729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43729--material-ui.netlify.app/ Bundle size report |
Janpot
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Can't wait for automatic resource managent to get wide spread adoption so that we can just do
using clock = useFakeTimers({ ... })only in the tests that need it instead of making a kitchen sink createRender with all these utilities that are unnecessary on many of the tests.
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the extensibility of the
useFakeTimersfunction by allowing override of all options.This might be most useful in providing a
toFake(doc) option to limit what is mocked.