Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material] Fix wrong import to type #43584

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[material] Fix wrong import to type #43584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/mui-material/src/utils/memoTheme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { CSSInterpolation } from '@mui/styled-engine';
import { CSSInterpolation } from '@mui/system';
import { Theme } from '../styles/createTheme';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Material UI should never import directly from @mui/styled-engine, all imports should go through @mui/system (then this package is configured to get the right type from either @mui/styled-engine or @mui/styled-engine-sc depending on which styling engine is used under the hood).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add an eslint rule to enforce this constraint?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I will look into it.


type ThemeStyleFunction = (props: { theme: Theme }) => CSSInterpolation;
Expand Down
Loading