Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Fix nextjs build cache #43467

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented Aug 27, 2024

Main changes:

Note: Should I also update the version in package.json? 🤔

@JCQuintas JCQuintas added the scope: code-infra Specific to the core-infra product label Aug 27, 2024
@JCQuintas JCQuintas self-assigned this Aug 27, 2024
@mui-bot
Copy link

mui-bot commented Aug 27, 2024

Netlify deploy preview

https://deploy-preview-43467--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against e6fd5b3

@JCQuintas JCQuintas requested a review from a team August 27, 2024 11:13
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense to me. 👍
Thank you for handling it. 🙏
Let's test it and see if we can avoid the ocassional build failures. 🤞

Should I also update the version in package.json? 🤔

I think that it won't hurt bumping the version thus aligning it with @mui/material. 👍

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Yes, removing the digests make sense. Still not 100% clear to me how this can cause the issue though. Next.js already only retains the .next/cache folder during a build. It still feels to me like there's something going wrong around the github: dependency.

@JCQuintas JCQuintas enabled auto-merge (squash) August 27, 2024 12:05
@JCQuintas JCQuintas merged commit 0d1578f into mui:master Aug 27, 2024
19 checks passed
@JCQuintas JCQuintas deleted the fix-nextjs-build-cache branch November 13, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants