[test] Update matchMedia mocks

[cherniavskii]

The usage of deprecated addListener/removeListener was removed from useMediaQuery in https://github.com/mui/material-ui/pull/42464/files#diff-29dc32373d28b87f1bf18f66cfb725f9dbad15b86a308c8453aa0ce38d15c748L92
describeConformance still mocks the deprecated methods, which makes the tests in MUI X fail when running against @mui/material@^6:

TypeError: mediaQueryList.addEventListener is not a function

This PR updates the matchMedia mocks to use addEventListener/removeEventListener.

[mui-bot]

Netlify deploy preview

• docs/data/material/components/use-media-query/use-media-query.md

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ed26c3e

[cherniavskii]

On second thought, it should mock both here to work with both v5 and v6.

[aarongarciah]

Not sure I follow. This PR is supposed to land on next (v6). How does keeping addListener/removeListener help v5?

[LukasTy]

Given the current release strategy for the internal packages, this should probably be a major release of the @mui/internal-test-utils and dropping the addListener altogether as the linked PR for removing Safari support did. 🤔
What do others think?
cc @mui/code-infra

[cherniavskii]

This PR is supposed to land on next (v6). How does keeping addListener/removeListener help v5?

We're using the @mui/internal-test-utils released from the next branch, but we can run our tests using either @mui/material v5 or v6. Since @mui/material@5 still uses addListener/removeListener, we need both to run the tests against both v5 and v6.
Does this make sense?

[aarongarciah]

Got it 👍

[Janpot]

Given the current release strategy for the internal packages, this should probably be a major release of the @mui/internal-test-utils

We're not following semver with internal packages. The strategy is to be always backwards compatible (*). So I believe supporting both as @cherniavskii does makes most sense to me 👍

(*) backwards compatible against our own code that is. As soon as none of our code uses the compatibility mode anymore, it can be dropped, even on a minor.

[cherniavskii]

Sounds good 👍🏻
This PR is ready for review then.

[cherniavskii]

Is the failed "CI / test-dev (macos-latest) (pull_request)" step a false alarm? I'm not sure my changes could have caused it 🤔

[Janpot]

Can't reproduce locally (pnpm --filter @app/next-app build). I'll rerun the job, just to make sure. Looks like one of those non-deterministic vite/Next.js getting confused over our strange ESM implementation. I've restarted the test just to make sure.

[Janpot]

Suggestion: It could be valuable to have a comment that explains why the legacy methods are still there and when they can be removed.