Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Bump React to 18.3.1 #42846

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

aarongarciah
Copy link
Member

@aarongarciah aarongarciah commented Jul 5, 2024

Contents of this PR:

  • Cherry-pick of [core] Bump React to 18.3.1 #42047
  • Bump of @testing-library/react and @testing-library/dom. As of React 18.3.1 act is no longer exported from react-dom/test-utils and is now exported from react. Older versions of @testing-library/react point to act in react-dom/test-utils, so we need to upgrade to a newer version. This can't be done in a separate PR because of some incompatible types.

We're backporting all changes to support React 18.3.1 from next to master. These are the changes to backport from next before we can merge this PR:

@aarongarciah aarongarciah added dependencies Update of dependencies core Infrastructure work going on behind the scenes labels Jul 5, 2024
@mui-bot
Copy link

mui-bot commented Jul 5, 2024

Netlify deploy preview

https://deploy-preview-42846--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against d2a9a96

@aarongarciah aarongarciah added React 19 support PRs required to support React 19 cherry-pick The PR was cherry-picked from the next branch labels Jul 5, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 5, 2024
renovate bot and others added 2 commits July 8, 2024 17:22
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 8, 2024
@aarongarciah
Copy link
Member Author

Finally a bump of @testing-library/dom and @testing-library/react was required to have a compatible React 18.3.1 testing setup, otherwise tests would fail due to some wrong types.

@aarongarciah aarongarciah marked this pull request as ready for review July 8, 2024 16:09
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@aarongarciah aarongarciah merged commit 3a920ad into mui:master Jul 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick The PR was cherry-picked from the next branch core Infrastructure work going on behind the scenes dependencies Update of dependencies React 19 support PRs required to support React 19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants