-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[docs-infra] Add design and formatting improvements #42063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Add design and formatting improvements #42063
Conversation
Netlify deploy previewhttps://deploy-preview-42063--material-ui.netlify.app/ Bundle size report |
Signed-off-by: Danilo Leal <[email protected]>
Quick bump on this one, so y'all double-check it! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design-wise, it looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated How to migrate messages look good. Nit: some of them ended up with duplicated periods due to preceding inconsistencies: Before this change, some of the "How to migrate" messages had a period while others didn't.
*/ | ||
TransitionComponent?: React.JSXElementConstructor< | ||
TransitionProps & { children?: React.ReactElement<any, any> } | ||
>; | ||
/** | ||
* Props applied to the transition element. | ||
* By default, the element is based on this [`Transition`](https://reactcommunity.org/react-transition-group/transition/) component. | ||
* @deprecated Use `slotProps.transition` instead. This prop will be removed in v7. [How to migrate](/material-ui/migration/migrating-from-deprecated-apis/). | ||
* @deprecated Use `slotProps.transition` instead. This prop will be removed in v7. See [Migrating from deprecated APIs](/material-ui/migration/migrating-from-deprecated-apis/) for more details.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sai6855, may I ask you to apply this change to your open PRs?
Tried to separate each little addition in individual/focused commits.
It can seem like a lot of changes, but most of them are changing the copywriting regarding migrating from deprecated APIs, which are found in several components (done in this commit 88d6d4a).