-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[material-ui][joy-ui] Move typography CSS variables to font
#42003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Netlify deploy previewhttps://deploy-preview-42003--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
@siriwatknp should I wait for this to be merged before the release? |
Yes, I think this should be included. |
@danilo-leal Could you take a look at this PR again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good — I don't see any of the regressions on the deploy preview! However, it might be worth clarifying how this new font
field solves/helps with that regression. Or even the benefit of using it, which isn't immediately clear to me.
Sure, this effort is a part of lifting the theme to CSS variables. It's useful for applications that are not limited to Material UI or React because they can access the theme using CSS. For example, using a plain CSS file to style a part of an application using the generated CSS variable from Material UI theme:
Or with Tailwind:
Will add these improvements to the docs. |
Regression from #41703
Changes related to
typography
in #41703 have been reverted. A new field,font
, is created to store typography token.usage: