Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Fix grid usage and add stray improvements #41930

Merged
merged 7 commits into from
Apr 17, 2024

Conversation

danilo-leal
Copy link
Contributor

This PR primarily switches the Grid usage to the Grid v2 as a bunch of sections relying on the v1 were broken for some reason. I'm not fully sure why; haven't dug deep. Aside from that, also added other varied improvements here and there throughout different pages and sections—housekeeping.

@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused. labels Apr 16, 2024
@danilo-leal danilo-leal self-assigned this Apr 16, 2024
@mui-bot
Copy link

mui-bot commented Apr 16, 2024

Netlify deploy preview

https://deploy-preview-41930--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b2a19cb

Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving an approval here, since my feedback are not blockers, but it looks good! Specially the tweaks you've added to the templates showcase 🚀

Screenshot 2024-04-17 at 10 54 27

@@ -35,7 +35,7 @@ export default function TemplateHero() {
<IconImage width={28} height={28} loading="eager" name="product-templates" /> Templates
</Typography>
<Typography variant="h1" sx={{ my: 2, maxWidth: 500 }}>
<GradientText>Fully built</GradientText> Material&nbsp;UI templates
<GradientText>Beautiful and fully built</GradientText> Material&nbsp;UI templates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you made a change here, I wonder if we should improve the all the content here. The subtitle, for instance, is the exact same in the following 'templates' section. Besides, regarding the title, I believe we'll have a Joy UI template soon, so having 'Material UI' might not be so accurate. That said, I think in the future this page could be replaced by MUI Store home screen, or the new templates page (that could already be the link in the CTA here)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the future this page could be replaced by MUI Store home screen

Not this Material UI page per se, but I'm totally onboard regarding deprecating the Design Kits and Templates page with the Store homepage. 👍

@danilo-leal danilo-leal merged commit f17f8d7 into mui:next Apr 17, 2024
22 checks passed
@danilo-leal danilo-leal deleted the website-adjustments branch April 17, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants