-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Fix grid usage and add stray improvements #41930
Conversation
Netlify deploy previewhttps://deploy-preview-41930--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -35,7 +35,7 @@ export default function TemplateHero() { | |||
<IconImage width={28} height={28} loading="eager" name="product-templates" /> Templates | |||
</Typography> | |||
<Typography variant="h1" sx={{ my: 2, maxWidth: 500 }}> | |||
<GradientText>Fully built</GradientText> Material UI templates | |||
<GradientText>Beautiful and fully built</GradientText> Material UI templates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you made a change here, I wonder if we should improve the all the content here. The subtitle, for instance, is the exact same in the following 'templates' section. Besides, regarding the title, I believe we'll have a Joy UI template soon, so having 'Material UI' might not be so accurate. That said, I think in the future this page could be replaced by MUI Store home screen, or the new templates page (that could already be the link in the CTA here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in the future this page could be replaced by MUI Store home screen
Not this Material UI page per se, but I'm totally onboard regarding deprecating the Design Kits and Templates page with the Store homepage. 👍
This PR primarily switches the Grid usage to the Grid v2 as a bunch of sections relying on the v1 were broken for some reason. I'm not fully sure why; haven't dug deep. Aside from that, also added other varied improvements here and there throughout different pages and sections—housekeeping.