Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pigment-css][react] Implement sx transform for system components #41861

Merged
merged 2 commits into from
Apr 12, 2024
Merged

[pigment-css][react] Implement sx transform for system components #41861

merged 2 commits into from
Apr 12, 2024

Conversation

brijeshb42
Copy link
Contributor

that don't support handling the transformed sx prop

@brijeshb42
[pigment-css][react] Implement sx transform for system
a00dc4e 
components that don't support handling the transformed sx prop
@brijeshb42
Implement runtime component
5201606
@brijeshb42 brijeshb42 added the package: pigment-css Specific to @pigment-css/* label Apr 11, 2024
@mui-bot
Copy link

mui-bot commented Apr 11, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41861--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 5201606

siriwatknp
siriwatknp approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Let's try this!

mnajdova
mnajdova approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we will need to port this to the new repo too.

@brijeshb42 brijeshb42 merged commit d31194c into mui:next Apr 12, 2024
20 checks passed
@brijeshb42 brijeshb42 deleted the pigment/sx-prop-alt branch April 12, 2024 11:35
@brijeshb42
Copy link
Contributor Author

Looks good, we will need to port this to the new repo too.

I'll do that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
package: pigment-css Specific to @pigment-css/*
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brijeshb42 @mui-bot @mnajdova @siriwatknp