[pigment-css][react] Fix sx prop transformation on Box #41705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brijeshb42
force-pushed
the
pigment/fix-box-sx
branch
from
e3d97d0
to
b3c47a2
Compare
Netlify deploy previewhttps://deploy-preview-41705--material-ui.netlify.app/ Bundle size report |
siriwatknp
reviewed
Mar 29, 2024
| @@ -1,6 +1,6 @@ | |||
| import * as React from 'react'; | |||
| import { useLocation, matchRoutes, Link } from 'react-router-dom'; | |||
| import { css } from '@pigment-css/react'; | |||
| import Box from '@pigment-css/react/Box'; | |||
There was a problem hiding this comment.
I guess there will be a question about the import in the future comparing:
import { css } from '@pigment-css/react';
import Box from '@pigment-css/react/Box';I think we should pick one way of import.
There was a problem hiding this comment.
I'd prefer import { Box } from '@pigment-css/react'; over default import.
There was a problem hiding this comment.
I'd prefer that everything is on a subpath. We don't want to repeat the same mistake of having barrel file exports from the start when we have control. Otherwise later, it'd harder to get the changes to be adopted by the user.
There was a problem hiding this comment.
Okay, let's use default export for Box. I added a task to move other APIs to the subpath before the stable beta release.
This current fix is very crude and does not handle the case when a user might have their own wrapper component over Box and they'll be passing sx prop through the component. Also made `Box` as a default import instead of name import. Fixes mui#41704
brijeshb42
force-pushed
the
pigment/fix-box-sx
branch
from
b3c47a2
to
231748a
Compare
siriwatknp
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This current fix is very crude and does not handle the case when a user might have their own wrapper component over Box and they'll be passing sx prop through the component. We need to have a better option to customize the condition.
Also made
Boxas a default import instead of name import.Fixes #41704