Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigment-css] Fix emotion styled error #41699

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Mar 29, 2024

Fix the error from emotion styled ("Cannot redefine toString") by pointing @emotion/styled to a dummy file. I do the same for styled-components as well because their source code also contain Object.defineProperty without configurable.

Tested locally with the next-app at /material-ui/react-switch.


@siriwatknp siriwatknp added bug 🐛 Something doesn't work package: pigment-css Specific to @pigment-css/* labels Mar 29, 2024
@mui-bot
Copy link

mui-bot commented Mar 29, 2024

Netlify deploy preview

https://deploy-preview-41699--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 083374e

@siriwatknp siriwatknp changed the title [pigment-css] Fix prop-types and emotion styled error [pigment-css] Fix emotion styled error Mar 29, 2024
@siriwatknp siriwatknp merged commit 9bcf6cf into mui:next Mar 29, 2024
19 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 29, 2024
tejasparkar pushed a commit to tejasparkar/material-ui that referenced this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work package: pigment-css Specific to @pigment-css/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants