-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][docs] Fix typo on the Accordion page #41687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
connorshea
commented
Mar 27, 2024
- I have followed (at least) the PR section of the contributing guide.
danilo-leal
changed the title
Update accordion.md to fix typo
[material-ui][docs] Fix typo on the Accordion page
Mar 27, 2024
danilo-leal
added
docs
Improvements or additions to the documentation
component: accordion
This is the name of the generic UI component, not the React module!
package: material-ui
Specific to @mui/material
labels
Mar 27, 2024
danilo-leal
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👍
Should I rebase this change on top of next to avoid the merge conflicts/extra commits? |
Yeah, please! 😬 Was about to do that myself in a few, but go ahead! |
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Mar 27, 2024
Signed-off-by: Connor Shea <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Mar 27, 2024
Updated 👍 |
hmm, do I need to do anything specific to get the remaining tests to run? |
Netlify deploy previewBundle size report |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Mar 29, 2024
tejasparkar
pushed a commit
to tejasparkar/material-ui
that referenced
this pull request
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: accordion
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
package: material-ui
Specific to @mui/material
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.