[core] Update peerDependencies ranges to include v6 packages #41662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
michaldudak
commented
Mar 26, 2024
•
michaldudak
commented
- Adds a missing @mui/material dev dependency to @mui/lab
- Updates peer dep version ranges in @mui/material-nextjs and @mui/lab
Netlify deploy previewhttps://deploy-preview-41662--material-ui.netlify.app/ Bundle size report |
michaldudak
changed the title
Janpot
reviewed
Mar 26, 2024
| @@ -50,7 +50,7 @@ | |||
| "peerDependencies": { | |||
| "@emotion/cache": "^11.11.0", | |||
| "@emotion/server": "^11.11.0", | |||
| "@mui/material": "^5.0.0", | |||
| "@mui/material": "workspace:^", | |||
There was a problem hiding this comment.
This is a peer dependency. Perhaps we need to add a dev dependency with "workspace:^"?
There was a problem hiding this comment.
Yes, this was on purpose. @mui/material is not actually used in development, so there's no need to have in devDependencies.
(technically, I don't think it's required to have it in peer dependencies either, but that's another topic)
There was a problem hiding this comment.
Yes, I'd either keep it in peer dependencies and add a dev dependency to make the lockfile sound, or just remove it from peer dependencies altogether
tejasparkar
pushed a commit
to tejasparkar/material-ui
that referenced
this pull request
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.