-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][material-ui][Autocomplete] Improve the options
prop description
#41591
[docs][material-ui][Autocomplete] Improve the options
prop description
#41591
Conversation
Netlify deploy previewhttps://deploy-preview-41591--material-ui.netlify.app/ Bundle size report |
options
prop descriptionoptions
prop description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pluvio72 Thanks for the pull request. You need to first update the prop description in the type definition at
material-ui/packages/mui-base/src/useAutocomplete/useAutocomplete.d.ts
Lines 283 to 286 in aff8f32
/** | |
* Array of options. | |
*/ | |
options: ReadonlyArray<Value>; |
pnpm proptypes
pnpm docs:api
This will update the proptypes and API documentation accordingly.
CC @samuelsycamore for the description wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This affects the Base UI package, which isn't open for contributions in the Core repository. Contributions for Base UI should be made to the separate repository at https://github.com/mui/base-ui.
cc @mj12albert
Ahh I see, so I cannot commit changes to |
@pluvio72 I believe we need to wait for now. If we make changes to the |
options
prop descriptionoptions
prop description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pluvio72 Thanks for the pull request. We separated the code that depended on Base UI into its own chunk within Material UI, so this PR is now unblocked. I've pushed the changes, and it looks good to merge.
Closes #41140! :)
Preview: https://deploy-preview-41591--material-ui.netlify.app/material-ui/api/autocomplete/#autocomplete-prop-options