-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Card] Convert to support CSS extraction #41580
Conversation
Netlify deploy previewhttps://deploy-preview-41580--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
I ignored this so far, it's not worth I think. We are anyway adding these example just to validate if it works, we are not going to actually use them as a docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
paddingBottom: 24, | ||
}, | ||
}; | ||
})({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, no need for a callback 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one 👍
Hey @siriwatknp, I see the assets have not been moved to the docs, should we update the script to do that as well?
Screen.Recording.2024-03-20.at.20.17.56.mov