[pigment-css][demo] Add index page for material-ui #41577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brijeshb42
commented
Mar 20, 2024
| @@ -51,7 +73,9 @@ export default function Breadcrumbs() { | |||
| <section> | |||
| <h2> Router Breadcrumbs</h2> | |||
| <div className="demo-container"> | |||
| <RouterBreadcrumbs /> | |||
| <ErrorBoundary FallbackComponent={ErrorBoundaryFallback}> | |||
| <RouterBreadcrumbs /> | |||
There was a problem hiding this comment.
I'll look into the actual fix separately. It's related to nested router usage. So for now, I've wrapped it in ErrorBoundary so that rest of the page works.
Netlify deploy previewhttps://deploy-preview-41577--material-ui.netlify.app/ Bundle size report |
components, similar to the one we have in the next.js demo
brijeshb42
force-pushed
the
pigment/vite-demo-index
branch
from
f3b7c94 to
f8ef3db
Compare
pluvio72
pushed a commit
to pluvio72/material-ui
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
components, similar to the one we have in the next.js demo