[material-ui][Typography] Fix Typography inherit variant styles #41308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keal Jones <[email protected]>
kealjones-wk
changed the title
Netlify deploy previewhttps://deploy-preview-41308--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
mnajdova
reviewed
Mar 1, 2024
Comment on lines
+49
to
+50
| lineHeight: 'inherit', | ||
| letterSpacing: 'inherit', |
There was a problem hiding this comment.
I would hold off this change until we start working on the breaking changes, just to make sure it won't break something in userland. cc @DiegoAndai
There was a problem hiding this comment.
Sounds good to me. We'll point this PR to the next branch when it's created, which should happen soon.
DiegoAndai
approved these changes
Apr 10, 2024
|
Thanks @kealjones-wk! Sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #38123 the styles were supposed to be moved from the theme into the styled component but
lineHeightandletterSpacingstyles were missed and it caused regressions when usingbutton.Styles that were not moved over: https://github.com/mui/material-ui/pull/38123/files#diff-48a50468b17f36e83faa75d3f1a78ba450b0c78d0cdc6ebfbe1cb27ec5130e1aR80-R81