[AppBar] Convert to support CSS extraction #41247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mnajdova
commented
Feb 23, 2024
•
mnajdova
commented
- I have followed (at least) the PR section of the contributing guide.
mnajdova
added
the
component: app bar
Netlify deploy previewhttps://deploy-preview-41247--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
62 tasks
mnajdova
commented
Mar 6, 2024
mnajdova
commented
Mar 6, 2024
| @@ -2,12 +2,14 @@ import path from 'path'; | |||
| import fse from 'fs-extra'; | |||
| import * as prettier from 'prettier'; | |||
|
|
|||
| function capitalize(string) { | |||
| function pascalCase(string) { | |||
There was a problem hiding this comment.
react-app-bar was throwing, it resulted in App-bar() which is not a valid function name, I've converted to using pascal case.
mnajdova
commented
Mar 6, 2024
| @@ -16,7 +16,7 @@ interface Props { | |||
| * You won't need it on your project. | |||
| */ | |||
| window?: () => Window; | |||
| children: React.ReactElement; | |||
| children?: React.ReactElement; | |||
There was a problem hiding this comment.
Converted the demos to not require children.
siriwatknp
reviewed
Mar 7, 2024
mnajdova
commented
Mar 7, 2024
Signed-off-by: Marija Najdova <[email protected]>
mnajdova
commented
Mar 7, 2024
Signed-off-by: Marija Najdova <[email protected]>
mnajdova
changed the title
mnajdova
changed the title
github-actions
bot
added
the
PR: out-of-date
siriwatknp
approved these changes
Mar 28, 2024
github-actions
bot
removed
the
PR: out-of-date
|
@siriwatknp I noticed bug while updating the branch, would be great if you can validate 1da33c9 |
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.