Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Alert] Add action, icon, and iconMapping tests #40682

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

DiegoAndai
Copy link
Member

While working on #40681 I noticed we were missing tests for the action, icon, and iconMapping props.

@DiegoAndai DiegoAndai added test package: material-ui Specific to @mui/material component: alert This is the name of the generic UI component, not the React module! labels Jan 18, 2024
@DiegoAndai DiegoAndai self-assigned this Jan 18, 2024
@mui-bot
Copy link

mui-bot commented Jan 18, 2024

Netlify deploy preview

https://deploy-preview-40682--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 222979a

Copy link
Member

@mj12albert mj12albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ~ 👍

@mj12albert mj12albert merged commit aa4260d into mui:master Jan 23, 2024
22 checks passed
@DiegoAndai DiegoAndai deleted the alert-missing-tests branch January 23, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: alert This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants