[Core] update components to es6 classes

[nathanmarks]

es6 class codemod update

With some inspiration from @oliviertassinari I was able to hack together a quick fork of react-codemod with a class converter that would enable some more es7 features (supported via babel, from the same proposal as the static properties).

Please check out the diff and point out anything that is screwed up! :+1

Also, I could not convert Snackbar because of the mixin it is using (resizable style something or other...). Hopefully that with an improved solution for styling the mixin will become obsolete anyways.

---

• PR has tests / docs demo, and is linted.
• Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
• Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

[nathanmarks]

@callemall/material-ui

One issue is that we currently depend on displayName for type checking. Classes don't have a displayName by default, you need to add it manually or use a babel transform to add it.

Should we do that for now? Or consider #3163 a hard dependency/blocker for this?

(btw, there is an eslint react plugin rule for enforcing displayName, feels gross though 😟 )

[newoga]

@nathanmarks My vote is use a babel transform if possible so that we can merge this (however we should still continue to discuss #3163).

[nathanmarks]

@newoga Want to check it out? I added that transform

[oliviertassinari]

@nathanmarks I'm definitely not convinced by the https://github.com/nathanmarks/babel-plugin-transform-react-es6-displayname/blob/master/index.js babel-plugin.
Using this plugin is definitely going to increase the size of the lib.
I would rather use the solution I have proposed before.

Few components need a static muiName property. That's going to be more explicit.
I think that the displayName is a debugging util, nothing more.
It feels wrong relying on it to make our components works.

[nathanmarks]

@oliviertassinari I will remove the plugin and manually add static muiName to the components that need type checking. Sounds good? 👍

[oliviertassinari]

@nathanmarks Awesome 👍.

[newoga]

isControlled() instead of _isControlled(), getControlledDate() too

[newoga]

Same here

[nathanmarks]

leaving for now as per our convo

[nathanmarks]

@callemall/material-ui need some more eyes giving this a review 👍

[mbrookes]

Tested every component in the docs site, and looks good here, (bar known-issues that are not related to this PR).

[nathanmarks]

@mbrookes whoo! awesome, thanks for reviewing 👍

[newoga]

Awesome stuff @nathanmarks!

[oliviertassinari]

@nathanmarks Awesome 💯.

[nathanmarks]

Thanks guys! Glad we got this in and can push on now 👍