[docs-infra] Move the Diamond Sponsors to the TOC #38410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-38410--material-ui.netlify.app/ Bundle size report |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
@oliviertassinari How are we doing with this one? Cool to move forward? |
oliviertassinari
approved these changes
Aug 14, 2023
|
The left sidebar scroll is broken, if you expand the components there is no way to scroll. @danilo-leal can you check before the release? |
|
Ah oops, I broke that when I worked on fixing the scroll restoration, I forgot to revert changes as I was trying different options. |
|
Oh wait no, I didn't broke it. It's the rebase that went wrong. |
oliviertassinari
added a commit
that referenced
this pull request
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #37933
In response to a recent email thread, and as a follow-up to our discussion, this PR moves the Diamond Sponsors to the table of contents. Want to acknowledge that on some pages (e.g. Material UI's Autocomplete, Text Field, Select, etc), they're not visible above the fold due to how big the TOC is. Not sure if we want to explore a similar solution to the current production design ⎯ where the sponsors stay fixed ⎯ so, let me know! Curious to discuss more and see how this resonates. Also, added back the "+1" box given that this positioning sort of allows for the list to grow bigger vertically without much interruption.
If this one moves along, I think it's reasonable to say that it: Closes #38033