-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Updated Remix examples with the lates changes using React 18 #35092
Conversation
|
Looks like this works. BTW could you reference what project you used as a reference. I am asking because the Remix's emotion example is still using React 17 and some older implementaiton. |
Hi @mnajdova - you know I searched (albeit fairly quickly) to find the new 'quickstart' app repo for Remix (not the Emotion example) - but couldn't find it. However, when you run this command |
Alright, this makes sense 👍 I guess their examples are not updated yet. I couldn't find anything out of place. |
just committed eslint and prettier fixes (apologies, commit messages are not 'conventional commits' - which I see now is the project's format) |
No worries, we squash and merge, so only one commit per PR is visible afterwards :) Thanks for fixing the issues |
From #34991
This should 'just work' with the updated
entry.client.tsx
for Remix latest and React 18Note that the latest
entry.server.tsx
in the Remix blog tutorial usesrenderToPipeableStream
, although based on emotion-js/emotion#2800 - I'm not sure this is possible yet.For interest only, below is what the
renderToPipeableStream
would look like inentry.server.tsx
if it were supported.Hope this helps.