-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve product identifier #32707
[docs] Improve product identifier #32707
Conversation
@danilo-leal I have completed the rest of the todos. Feel free to do the final adjustment in |
This comment was marked as resolved.
This comment was marked as resolved.
fyi: I've been chewing on the description showing as we hover the chips and I haven't been really feeling it. It forces having that extra (unbalanced and weird) white space for the description text, and ultimately having both of them (MUI Core's description and each sub-product respectively) looks too busy. I'm leaving it commented for now if we feel like going back to this iteration later on, but, for now, my take is to go without it! Additionally, each chip should direct to the Overview page of each product-we're in the process of writing those for the remaining products (Base is the only one that's currently released). So I might come back and change that in a follow-up pull request once they're done. |
…ove-product-identifier
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think that we have an issue with the UX of the menu (same in https://mui.com/) when leaving the hover of an area, but moving the mouse over the fading away menu, then it reappears. See https://stripe.com/ and https://www.radix-ui.com/docs/primitives/components/navigation-menu for what I think would be a UX that heaves predictably (and hence feel great). I have noticed it moving between the popup of "Products" to "Docs". It would show the "Products" popup instead of the "Docs" one.
- For the details description of each product, did we consider updating the main description with a fade on hover, e.g. when hovering "MUI System"?
|
|
|
@danilo-leal I have fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Great work @danilo-leal !
Looks much better 👍 great job @danilo-leal 🥳 |
Closes #32591
To-dos on the docs:
To-dos on the website:
Extras: