Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ListItem] Add support for CSS variables #32580

Merged
merged 2 commits into from
May 4, 2022
Merged

[ListItem] Add support for CSS variables #32580

merged 2 commits into from
May 4, 2022

Conversation

dan-mba
Copy link
Contributor

@dan-mba dan-mba commented May 3, 2022

One of #32049

cc: @mui/contributors
(I'm not sure if this at reference is working because it doesn't show as a link)

@mui-bot
Copy link

mui-bot commented May 3, 2022

Details of bundle changes

@material-ui/core: parsed: +0.11% , gzip: +0.07%

Generated by 🚫 dangerJS against 60cbcff

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! 👍

cc: @mui/contributors
(I'm not sure if this at reference is working because it doesn't show as a link)

It's better if you can just request review from mui/core

theme.palette.action.selectedOpacity + theme.palette.action.focusOpacity,
),
backgroundColor: theme.vars
? `rgba(${theme.vars.palette.primary.mainChannel} / calc(${theme.vars.palette.action.selectedOpacity} + ${theme.vars.palette.action.focusOpacity}))`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that we can even use calc for calculating the opacity 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it:

@dan-mba
Copy link
Contributor Author

dan-mba commented May 3, 2022

Looks great, thanks! 👍

cc: @mui/contributors
(I'm not sure if this at reference is working because it doesn't show as a link)

It's better if you can just request review from mui/core

How do you request a review? I don't have the gear icon next to reviewers like you do.

@danilo-leal danilo-leal added component: list This is the name of the generic UI component, not the React module! new feature New feature or request labels May 3, 2022
@siriwatknp siriwatknp merged commit a30a4f5 into mui:master May 4, 2022
@dan-mba dan-mba deleted the list-item-css branch May 4, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: list This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants