Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Refine home, pricing and about pages #27927

Merged
merged 90 commits into from
Aug 27, 2021

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Aug 23, 2021

Preview pages

Perfomance

Good to go!
https://webpagetest.org/video/compare.php?tests=210826_AiDcEW_12eeae53592aadc3593d6feffcdb00bb%2C210826_BiDcMQ_da93be69ea92c948d93d421492502f9a%2C210826_BiDc46_f17c4522340bf8a8a9fd14cbee549051&thumbSize=200&ival=500&end=visual

Common

  • Email Subscribe UX @danilo-leal @oliviertassinari the code is copied from old rebranding. If you subscribe, you will see green alert (replace the input) tell u to check your inbox. Do we want to go with this UX?
  • Land on homepage with Toast after confirm in the inbox.
  • SendInBlue setup (group, naming ...) @oliviertassinari @mbrookes I have created form "Newsletter" in sendinblue, please recheck if I missed anything.
  • dark mode primary.main color @danilo-leal I think the primary.main color need to be brighter in dark mode. We did it for docs before. (primary.400 works great with primaryDark.700, 800, 900)
    Screen Shot 2564-08-24 at 09 16 02
  • remove passHref from all component={Link} since the prop is true by default [docs] Fix missing href for AppDrawerNavItems #27936

Header

  • keyboard navigation on menus (← →)
  • npm install should be @material-ui/core @oliviertassinari @danilo-leal From my understanding, we are not changing the package name at v5.0.0. wait for confirmation.
  • I saw with the nav menu on small screens. When I can't see the whole menu and try to scroll down, only the background scrolls.
  • Hide products menu (enable it once all product pages are done)
  • add tooltip to mode toggle @danilo-leal is this better than not having?
    Screen Shot 2564-08-24 at 15 15 59
  • add search bar

Home

  • social share image og:image @danilo-leal we need to change the image for social sharing, can you provide one in figma? I can take care of the rest.
  • Rich result status reports (use the same as current index page)
  • code highlight in core showcase is not align (only mobile device)
  • metadata in core showcase at custom design
  • weird shadow in designkits & template showcase (only mobile device)
  • Add non breaking space between "your" & "UI" to prevent the hanging "UI"?
    image
  • Align user logo baselines
  • Diamond sponsor logos should be bigger than gold
  • Diamond sponsor card should be bigger than gold? @danilo-leal
  • Ii might be intentional, but the external link icon moving on hover looks like a bug:
    image
  • Diamond / gold footer on every card seems redundant, and makes the sponsors section larger than it needs to be. A heading might be better
  • "Check it for yourself, give it a try and share with us what you've built!" -> "Try it for yourself, and share with us what you've built!"
  • "Showcases" -> "Showcase"
  • "See more projects and companies that rely on MUI."
  • We're still leaking internal meta-labels. Is it intentional? If the heading doesn't communicate the intention of the section, might it be better to improve the copy. (Partially fixed by making it h1)
    image
  • Dark mode setting isn't retained when switching to the docs
  • "Hover the component for highlighting the code." -> "Hover the component to highlight the code".
  • The right margin of the code preview doesn't match the rest of the copy.
  • DataGrid in advance showcase create new style every time the mode changes

Pricing

table.crop.mov
  • Icons not centered:
    image
    Edit: Actually, looking at the alignment of the scroll-view header, it seems it might be intentional. Let's revert it and center both. It doesn't look right.
  • Table rows have a hover indicator but clicking anything other than the Data grid accordion doesn't do anything, breaking expectations. no bg for the table row on touch device
  • Data grid accordion headerhas smaller height than other table rows.
  • Data grid accordion icon transition feels much too slow.
  • When the accordion is collapsed, the data grid doesn't appear to be included in any plan. Suggest a "partial" icon (empty circle?) for Community, and checkmark for Pro and Premium, only when not open.
  • "$0 / Free forever" -> "$0 – free forever".
  • "$186 / per developer" -> "$186 / developer" or "$186 per developer".
  • There seems to be a spacing issue with the icon:
    image

About us

  • social share image og:image @danilo-leal
  • Join the team link? @danilo-leal should I build the career page in figma right in this PR?
  • Tooltip bg-color @danilo-leal I will make the bg darker for the light mode and add some shadow.
    Screen Shot 2564-08-24 at 09 30 29

Footer

  • links (hidden some that are not available) @oliviertassinari @danilo-leal
    Screen Shot 2564-08-24 at 14 07 58
  • "Copyright © 2021 MATERIAL-UI SAS." -> "Copyright © 2021 Material-UI SAS."

@mui-pr-bot
Copy link

mui-pr-bot commented Aug 23, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 457a0a5

@danilo-leal

This comment has been minimized.

@danilo-leal
Copy link
Contributor

@oliviertassinari @mbrookes

We're referring to the advanced components in three different ways: Advanced, MUI X and Advanced X. We should standardize and commit to one of them... I'd think that ditching the lonely Advanced is the first move since the packages will have x as pre-fix and it's probably a good thing to resonate with that. And, in order to not have to name the Core as MUI Core as well, I'd personally vote for using Advanced X. It might sound a bit redundant but overall I think it's fine. Using only X feels too empty for me. Great for the packages but weird for written text. This is just my opinion... I'd like to get your perspective on the matter so we launch these pages with the right name in each instance.

@siriwatknp
Copy link
Member Author

@danilo-leal What do you think about this (after clicking confirm in the email will land on homepage with Toast)?

Screen.Recording.2564-08-27.at.10.01.39.mov

@siriwatknp siriwatknp marked this pull request as ready for review August 27, 2021 04:23
@siriwatknp siriwatknp requested a review from mnajdova August 27, 2021 07:01
@mnajdova
Copy link
Member

  1. Could we have fix height on the div around so that the page don't jump when they are loaded:

  1. Maybe the placeholder can have a lighter color:

  1. Not critical but we may wanna fix it later:

  1. I remember we had nice animations here:

Were they removed because of perf?


These were all things I could find, nothing is critical tough... Very good job @siriwatknp & @danilo-leal 🤩

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left couple of comments, rest looks 💯

@siriwatknp
Copy link
Member Author

siriwatknp commented Aug 27, 2021

1 Could we have fix height on the div around so that the page don't jump when they are loaded:

fixed

  1. Maybe the placeholder can have a lighter color:

I think it is light enough 🤔. May be @danilo-leal can decide.

  1. Not critical but we may wanna fix it later:

@danilo-leal should we do it?

I remember we had nice animations here:

which animation?

@siriwatknp siriwatknp merged commit 8d4977f into mui:next Aug 27, 2021
@oliviertassinari oliviertassinari added the website Pages that are not documentation-related, marketing-focused. label Aug 27, 2021
Comment on lines +263 to +269
<GlobalStyles
styles={{
html: {
fontSize: theme.typography.htmlFontSize, // for Safari (>=14.1.2)
},
}}
/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is suspicious. I think that it should either:

  • be inside the CssBaseline if it fixes the root cause of a problem
  • not be required if the issue is that we missed Typography wrappers in a few places

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, isn't it breaking the font size accessibility of the page? I can no longer use:

Capture d’écran 2021-08-27 à 12 59 24

to remove.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliviertassinari it is removed in #27956

@mbrookes
Copy link
Member

mbrookes commented Aug 27, 2021

Just spotted another "leverage":
image

Not sure if we're doing another round before release, but it would be good to fix that at some point.

@danilo-leal
Copy link
Contributor

@mbrookes Just FYI: changed from "leverage" to "use" on this commit f8aa03f on the currently open #27956 PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants