-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Refine home, pricing and about pages #27927
Conversation
This comment has been minimized.
This comment has been minimized.
We're referring to the advanced components in three different ways: Advanced, MUI X and Advanced X. We should standardize and commit to one of them... I'd think that ditching the lonely Advanced is the first move since the packages will have |
…l-ui into rebranding/refinement
@danilo-leal What do you think about this (after clicking confirm in the email will land on homepage with Toast)? Screen.Recording.2564-08-27.at.10.01.39.mov |
Were they removed because of perf? These were all things I could find, nothing is critical tough... Very good job @siriwatknp & @danilo-leal 🤩 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left couple of comments, rest looks 💯
fixed
I think it is light enough 🤔. May be @danilo-leal can decide.
@danilo-leal should we do it?
which animation? |
<GlobalStyles | ||
styles={{ | ||
html: { | ||
fontSize: theme.typography.htmlFontSize, // for Safari (>=14.1.2) | ||
}, | ||
}} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is suspicious. I think that it should either:
- be inside the CssBaseline if it fixes the root cause of a problem
- not be required if the issue is that we missed Typography wrappers in a few places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oliviertassinari it is removed in #27956
Preview pages
Perfomance
Good to go!
https://webpagetest.org/video/compare.php?tests=210826_AiDcEW_12eeae53592aadc3593d6feffcdb00bb%2C210826_BiDcMQ_da93be69ea92c948d93d421492502f9a%2C210826_BiDc46_f17c4522340bf8a8a9fd14cbee549051&thumbSize=200&ival=500&end=visual
Common
primary.main
color need to be brighter in dark mode. We did it for docs before. (primary.400
works great withprimaryDark.700, 800, 900
)passHref
from allcomponent={Link}
since the prop is true by default [docs] Fix missinghref
for AppDrawerNavItems #27936Header
@material-ui/core
@oliviertassinari @danilo-leal From my understanding, we are not changing the package name at v5.0.0. wait for confirmation.products
menu (enable it once all product pages are done)Home
h1
)DataGrid in advance showcase create new style every time the mode changesPricing
no
icontable.crop.mov
Edit: Actually, looking at the alignment of the scroll-view header, it seems it might be intentional. Let's revert it and center both. It doesn't look right.
Table rows have a hover indicator but clicking anything other than the Data grid accordion doesn't do anything, breaking expectations.no bg for the table row on touch deviceAbout us
Footer