[DatePicker] Call setState-muiTheme in componentWillReceiveProps #2579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatePicker does not update state.muiTheme on componentWillReceiveProps, resulting in the child component (TextField) not receiving updated theme values.
Side note - would this conditional way of calling
this.setState
save a few milliseconds of calculation as compared to callingthis.setState{muiTheme:...}
without any checks like in all other components?