Repository navigation
[test] Fix focus return after Escape hover leave - #4906
Merged
Merged
Conversation
atomiks
added
component: menu
ChatGPT Codex Connector
commit: |
Bundle size
PerformanceTotal duration: 1,098.47 ms -201.49 ms(-15.5%) | Renders: 50 (+0) | Paint: 1,663.33 ms -290.69 ms(-14.9%)
9 tests within noise — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
force-pushed
the
codex/menu-escape-hover-focus
branch
from
May 26, 2026 10:38
e841e27 to
e913f7c
Compare
atomiks
changed the title
atomiks
added
test
and removed
component: menu
atomiks
changed the title
atomiks
marked this pull request as ready for review
May 26, 2026 11:04
atomiks
requested review from
colmtuite,
flaviendelangle and
michaldudak
as code owners
May 26, 2026 11:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4898
This PR is now test-only coverage for the Escape focus-return regression. The underlying click-opened menu behavior was fixed by #4893 (
94a9d1e6a), which added the hover-open guard inuseHoverFloatingInteraction.The new Chromium regression:
130e60323)masterIt keeps coverage for the case where a menu is closed with Escape while its popup remains mounted for an exit transition, then the positioner receives a late
mouseleavebecause pointer-events change under the resting pointer.Changes
mouseleave.