[composite] Rollback CompositeList to use counter-based update
#2880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
chuganzy
changed the title
chuganzy
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
romgrk
reviewed
Oct 1, 2025
Comment on lines
30
to
33
| // `mapTick` intentionally uses a counter-based update rather than unique objects. | ||
| // This is because the chance of precision loss in the counter is extremely low, | ||
| // while `mapTick` updates relatively often and is more memory-efficient. | ||
| const [mapTick, setMapTick] = React.useState(0); |
Contributor
There was a problem hiding this comment.
The comment is too long relatively to the importance of that line of code. I'd compact it in a single-line comment.
Contributor
Author
There was a problem hiding this comment.
Thanks for reviewing and pushed a commit to shorten it
4ccac87
romgrk
approved these changes
Oct 1, 2025
LukasTy
approved these changes
Oct 2, 2025
Member
LukasTy
left a comment
LukasTy
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for taking care of it. 🙏
LukasTy
changed the title
CompositeList to use counter-based update
LukasTy
added
the
type: enhancement
Bundle size report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just rollbacks
mapTickin theCompositeListto use counter-based update for the better memory-efficiency.Theads: #2675 (comment)