[examples] Revert examples deletion #2783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested review from
atomiks and
michaldudak
as code owners
oliviertassinari
added
type: regression
oliviertassinari
force-pushed
the
restore-examples
branch
from
5defac9 to
f1ffe24
Compare
commit: |
Bundle size report
|
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
approved these changes
Sep 18, 2025
Contributor
atomiks
left a comment
atomiks
left a comment
There was a problem hiding this comment.
There was a merge issue in that PR or something as it displayed it as adding the entire examples folder as part of the changed files. From Michal's review I deleted it but it ended up deleting it from the main branch as well.
oliviertassinari
added
the
scope: all components
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples folder was deleted in #2105, but 1. the PR seems off topic to delete it, 2. I don't see a discussion related to it and 3. we still have code that assumes that
examplesexists (eslint, pnpm), so I conclude that it was a rebase conflict.It's back now, apply #1885 back.
Side note 1. I don't quite understand why the example doesn't have:
Side note 2. I think #1885 (comment) is accurate, I think having example templates harms the DX for maintainers because it trains people (mind that if we execute perfectly, 80%+ of the PRs would come from the community, not us) to use the wrong path (the right path is to start from a demo, to only install the npm packages that you need, we can't scale with one npm package), but for new users, I find this useful to have something that they can easily play with. I could see growing to add more examples: Storybook, Tailwind CSS, etc.