[scroll area] Fix RTL horizontal scrollbar on Safari #2776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
added
type: bug
atomiks
force-pushed
the
fix/scroll-area-rtl-safari-2
branch
from
da0741a to
ab50551
Compare
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
the
PR: out-of-date
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle size report
|
github-actions
bot
removed
the
PR: out-of-date
commit: |
atomiks
force-pushed
the
fix/scroll-area-rtl-safari-2
branch
from
8c9f4c2 to
ab50551
Compare
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: atomiks <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
atomiks
force-pushed
the
fix/scroll-area-rtl-safari-2
branch
from
141d15e to
dbc4de1
Compare
LukasTy
reviewed
Sep 18, 2025
Member
LukasTy
left a comment
LukasTy
left a comment
There was a problem hiding this comment.
Are you sure it fixes the horizontal scrollbar? 🤔
The below screenshots are from the deployed docs.
Safari
Chrome
Contributor
Author
|
@LukasTy welp, the tests were failing with just I think for RTL we have to assume the margin is symmetric and avoid |
LukasTy
approved these changes
Sep 18, 2025
Member
LukasTy
left a comment
LukasTy
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing it. 👍
If we get reported problems with this approach, it can be adjusted. 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getOffset(...)value when calculatingmarginoffset on the scrollbar is reported differently in Safari compared to Chrome/Firefox. Switching to logical properties (as we also switched to use use logical functional CSS a while back) fixes the issuehttps://deploy-preview-2776--base-ui.netlify.app/experiments/scroll-area/scroll-area-inset