Skip to content

[accordion][toggle group] Unify multiple prop name to multiple #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2025
Merged

[accordion][toggle group] Unify multiple prop name to multiple #2764

merged 2 commits into from
Sep 17, 2025

Conversation

@LukasTy
Copy link
Member

@LukasTy LukasTy commented Sep 15, 2025

Fixes #1075

  • [BC] Rename Accordion's openMultiple prop to multiple
  • [BC] Rename Toggle Group's toggleMultiple prop to multiple

@LukasTy LukasTy self-assigned this Sep 15, 2025
@LukasTy LukasTy added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. component: accordion Changes related to the accordion component. breaking change Introduces changes that are not backward compatible. component: toggle group Changes related to the toggle group component. labels Sep 15, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 15, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@2764

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@2764

commit: 0a810ac

@netlify
Copy link

netlify bot commented Sep 15, 2025

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 0a810ac
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/68c7f09230c19e00085842d1
😎 Deploy Preview https://deploy-preview-2764--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mui-bot
Copy link

mui-bot commented Sep 15, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react ▼-10B(0.00%) ▼-8B(-0.01%)

Details of bundle changes

@LukasTy LukasTy marked this pull request as ready for review September 15, 2025 11:51
@LukasTy LukasTy merged commit daf6d92 into mui:master Sep 17, 2025
23 checks passed
@LukasTy LukasTy deleted the refactor/multiple-prop branch September 17, 2025 09:49
@brijeshb42 brijeshb42 mentioned this pull request Sep 24, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atomiks atomiks atomiks approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

Assignees

@LukasTy LukasTy

Labels

breaking change Introduces changes that are not backward compatible. component: accordion Changes related to the accordion component. component: toggle group Changes related to the toggle group component. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[accordion][select][toggle group] Decide on a common prop name for multiple active items

3 participants

@LukasTy @mui-bot @atomiks