Skip to content

[switch] Fix duplicate name attribute #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 16, 2025
Merged

[switch] Fix duplicate name attribute #2763

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17e3daa
Fix Switch name prop
mj12albert Sep 15, 2025
d43d6c6
Extra test
mj12albert Sep 16, 2025
6f7dd10
Merge remote-tracking branch 'upstream/master' into fix/switch-name-prop
mj12albert Sep 16, 2025
81ebebb
Merge branch 'master' into fix/switch-name-prop
mj12albert Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/react/src/switch/root/SwitchRoot.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,11 +200,14 @@ describe('<Switch.Root />', () => {
expect(thumb).not.to.have.attribute('data-checked');
});

it('should set the name attribute on the input', async () => {
it('should set the name attribute only on the input', async () => {
const { getByRole } = await render(<Switch.Root name="switch-name" />);

const switchElement = screen.getByRole('switch');
const input = getByRole('checkbox', { hidden: true });

expect(input).to.have.attribute('name', 'switch-name');
expect(switchElement).not.to.have.attribute('name');
});

describe('Form', () => {
Expand Down
7 changes: 3 additions & 4 deletions packages/react/src/switch/root/SwitchRoot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export const SwitchRoot = React.forwardRef(function SwitchRoot(
defaultChecked,
id: idProp,
inputRef: externalInputRef,
name: nameProp,
nativeButton = true,
onCheckedChange: onCheckedChangeProp,
readOnly = false,
Expand All @@ -61,7 +62,7 @@ export const SwitchRoot = React.forwardRef(function SwitchRoot(
} = useFieldRootContext();

const disabled = fieldDisabled || disabledProp;
const name = fieldName ?? elementProps.name;
const name = fieldName ?? nameProp;

const {
getValidationProps,
Expand Down Expand Up @@ -252,9 +253,7 @@ export const SwitchRoot = React.forwardRef(function SwitchRoot(
return (
<SwitchRootContext.Provider value={state}>
{element}
{!checked && elementProps.name && (
<input type="hidden" name={elementProps.name} value="off" />
)}
{!checked && nameProp && <input type="hidden" name={nameProp} value="off" />}
<input {...inputProps} />
</SwitchRootContext.Provider>
);
Expand Down
Loading