Skip to content

[combobox] Avoid deriving initial input value for input-inside-popup pattern #2752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2025
Merged

[combobox] Avoid deriving initial input value for input-inside-popup pattern #2752

merged 2 commits into from
Sep 17, 2025

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented Sep 12, 2025

Tweak to #2680 for input-inside-popup combobox patterns

@atomiks atomiks added the component: combobox Changes related to the combobox component. label Sep 12, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 12, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@2752

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@2752

commit: 4ecc844

@mui-bot
Copy link

mui-bot commented Sep 12, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react 🔺+130B(+0.04%) 🔺+15B(+0.01%)

Details of bundle changes

@netlify
Copy link

netlify bot commented Sep 12, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 4ecc844
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/68ca6f8667e8ee0008e0a7d3
😎 Deploy Preview https://deploy-preview-2752--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks marked this pull request as ready for review September 15, 2025 06:39
@atomiks atomiks merged commit d29aad5 into mui:master Sep 17, 2025
20 checks passed
@atomiks atomiks deleted the fix/combobox-default-value branch September 17, 2025 08:27
@brijeshb42 brijeshb42 mentioned this pull request Sep 24, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnajdova mnajdova mnajdova approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

Assignees

No one assigned

Labels

component: combobox Changes related to the combobox component.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atomiks @mui-bot @mnajdova