[select] block opening the popup when provided readOnly
#2717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seongminn
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
commit: |
Bundle size report
|
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
reviewed
Sep 10, 2025
|
|
||
| keyboardActiveRef.current = true; | ||
|
|
||
| if (event.key === 'ArrowDown') { |
Contributor
There was a problem hiding this comment.
Should this code block actually exist - is there a test covering it? useListNavigation should handle the logic already
Contributor
Author
There was a problem hiding this comment.
That makes sense. It's clear now that the logic in onKeyDown is redundant since it's covered by useListNavigation.
I have one follow-up question, though. Am I correct in thinking that the keyboardActiveRef is still necessary to track keyboard activity?
Contributor
There was a problem hiding this comment.
Yeah; it should just be the if (...) block that's redundant.
Contributor
Author
There was a problem hiding this comment.
Did it here. Thank you for your feedback!
atomiks
added
component: select
atomiks
approved these changes
Sep 11, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2715