Skip to content

[useRender] Add div as a defaultTagName #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 10, 2025
Merged

[useRender] Add div as a defaultTagName #2692

merged 4 commits into from
Sep 10, 2025

Conversation

@mnajdova
Copy link
Member

@mnajdova mnajdova commented Sep 8, 2025

Fixes #2690

@mnajdova mnajdova added type: bug It doesn't behave as expected. scope: useRender labels Sep 8, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 8, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@2692

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@2692

commit: 0ef18d4

@netlify
Copy link

netlify bot commented Sep 8, 2025

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 9691824
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/68beeaed156cda00086b94f0
😎 Deploy Preview https://deploy-preview-2692--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mui-bot
Copy link

mui-bot commented Sep 8, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react 🔺+7B(0.00%) 🔺+2B(0.00%)

Details of bundle changes

@mnajdova mnajdova changed the title [useRender] Add div as a defaultTagName [useRender] Add div as a defaultTagName Sep 8, 2025
@netlify
Copy link

netlify bot commented Sep 8, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 0ef18d4
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/68c16cd1eed8c7000811d0a3
😎 Deploy Preview https://deploy-preview-2692--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

LukasTy
LukasTy approved these changes Sep 8, 2025
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mnajdova mnajdova marked this pull request as ready for review September 10, 2025 12:19
@mnajdova mnajdova merged commit cde2c03 into mui:master Sep 10, 2025
19 checks passed
atomiks pushed a commit to atomiks/base-ui that referenced this pull request Sep 10, 2025
@mnajdova @atomiks
[useRender] Add div as a defaultTagName (mui#2692)
ebed42b
atomiks pushed a commit to atomiks/base-ui that referenced this pull request Sep 10, 2025
@mnajdova @atomiks
[useRender] Add div as a defaultTagName (mui#2692)
95a8d61
@brijeshb42 brijeshb42 mentioned this pull request Sep 24, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukasTy LukasTy LukasTy approved these changes

@atomiks atomiks atomiks approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

Assignees

No one assigned

Labels

type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

useRender defaultTagName documents "div" default but isn't optional

4 participants

@mnajdova @mui-bot @LukasTy @atomiks