-
-
Notifications
You must be signed in to change notification settings - Fork 263
[combobox][autocomplete] Refactor cols to grid prop
#2683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle size report
|
2840a95 to
c9d014a
Compare
cols to grid propcols to grid prop
Signed-off-by: atomiks <[email protected]>
Signed-off-by: atomiks <[email protected]>
|
Toolbar also exposes the |
|
@mj12albert yeah possibly; makes sense I think it's ok to leave it different for the time being, but that is something we need to look at |
michaldudak
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Introduces changes that are not backward compatible.
component: autocomplete
Changes related to the autocomplete component.
component: combobox
Changes related to the combobox component.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The composite logic was updated midway through development to read column sizes from DOM rows (to handle uneven / filtered rows). This prop to manually specify column size then became redundant and can just be a bool, as
Combobox.Rowis required when building a grid list.