Skip to content

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented Sep 8, 2025

The composite logic was updated midway through development to read column sizes from DOM rows (to handle uneven / filtered rows). This prop to manually specify column size then became redundant and can just be a bool, as Combobox.Row is required when building a grid list.

@atomiks atomiks added breaking change Introduces changes that are not backward compatible. component: combobox Changes related to the combobox component. labels Sep 8, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 8, 2025

vite-css-base-ui-example

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@2683
pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@2683

commit: e0d5a51

@netlify
Copy link

netlify bot commented Sep 8, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit e0d5a51
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/68d253c3fd3419000898b30e
😎 Deploy Preview https://deploy-preview-2683--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mui-bot
Copy link

mui-bot commented Sep 8, 2025

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react ▼-1B(0.00%) 🔺+2B(0.00%)

Details of bundle changes

@atomiks atomiks force-pushed the refactor/combobox-grid branch from 2840a95 to c9d014a Compare September 8, 2025 05:27
@atomiks atomiks changed the title [combobox] Refactor cols to grid prop [combobox][autocomplete] Refactor cols to grid prop Sep 8, 2025
@atomiks atomiks added scope: autocomplete component: autocomplete Changes related to the autocomplete component. labels Sep 8, 2025
@atomiks atomiks marked this pull request as ready for review September 8, 2025 11:42
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 10, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 10, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 11, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 11, 2025
@mj12albert
Copy link
Member

Toolbar also exposes the cols prop directly but I'm starting to think it's a mistake, and that it should be a role="grid" widget if it has grid-like keyboard nav 🤔

@atomiks
Copy link
Contributor Author

atomiks commented Sep 23, 2025

@mj12albert yeah possibly; makes sense

I think it's ok to leave it different for the time being, but that is something we need to look at

@atomiks atomiks merged commit 114a495 into mui:master Sep 23, 2025
20 checks passed
@atomiks atomiks deleted the refactor/combobox-grid branch September 23, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Introduces changes that are not backward compatible. component: autocomplete Changes related to the autocomplete component. component: combobox Changes related to the combobox component.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants