Skip to content

[slider] Remove redundant hidden inputs #2631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2025
Merged

[slider] Remove redundant hidden inputs #2631

merged 2 commits into from
Sep 9, 2025

Conversation

@mj12albert
Copy link
Member

@mj12albert mj12albert commented Sep 4, 2025 •
edited
Loading

Breaking: The inputRef prop is moved from Root to Thumb

Since the range input elements are focusable now (previously had tabindex="-1") the hidden inputs are no longer needed to integrate with forms; also makes more sense for inputRef to be on the thumb since the input element isn't hidden to developers anymore

Follow up to #2575 (comment)

@mj12albert mj12albert added the component: slider Changes related to the slider component. label Sep 4, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 4, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@2631

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@2631

commit: 7a9610a

@netlify
Copy link

netlify bot commented Sep 4, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 7a9610a
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/68bfa2ec9f28710008b17762
😎 Deploy Preview https://deploy-preview-2631--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mui-bot
Copy link

mui-bot commented Sep 4, 2025 •
edited
Loading

Bundle size report

Total Size Change: ▼-610B(-0.04%) - Total Gzip Change: ▼-176B(-0.03%)
Files: 71 total (0 added, 0 removed, 2 changed)

Show details for 71 more bundles

@base-ui-components/react/slider parsed: ▼-308B(-1.18%) gzip: ▼-110B(-1.11%)
@base-ui-components/react parsed: ▼-302B(-0.09%) gzip: ▼-66B(-0.06%)
@base-ui-components/react/accordion parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/alert-dialog parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/autocomplete parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/avatar parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/checkbox parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/checkbox-group parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/collapsible parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/combobox parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/context-menu parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/dialog parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/direction-provider parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/field parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/fieldset parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/form parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/input parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/menu parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/menubar parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/merge-props parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/meter parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/navigation-menu parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/number-field parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/popover parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/preview-card parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/progress parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/radio parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/radio-group parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/scroll-area parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/select parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/separator parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/switch parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/tabs parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/toast parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/toggle parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/toggle-group parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/toolbar parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/tooltip parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/types parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/unstable-no-ssr parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/unstable-use-media-query parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/react/use-render parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/detectBrowser parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/error parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/fastObjectShallowCompare parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/generateId parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/getReactElementRef parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/inertValue parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/isElementDisabled parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/isMouseWithinBounds parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/mergeObjects parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/owner parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/reactVersion parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/safeReact parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/store parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/useAnimationFrame parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/useControlled parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/useEnhancedClickHandler parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/useEventCallback parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/useForcedRerendering parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/useId parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/useInterval parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/useIsoLayoutEffect parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/useLatestRef parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/useMergedRefs parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/useOnFirstRender parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/useOnMount parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/useRefWithInit parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/useTimeout parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/visuallyHidden parsed: 0B(0.00%) gzip: 0B(0.00%)
@base-ui-components/utils/warn parsed: 0B(0.00%) gzip: 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 3941d9e

@mui-bot
Copy link

mui-bot commented Sep 4, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react ▼-302B(-0.09%) ▼-65B(-0.06%)

Details of bundle changes

@mj12albert mj12albert force-pushed the fix/slider-hidden-input branch from 1b99aa2 to b77ccbd Compare September 4, 2025 08:57
@mj12albert mj12albert marked this pull request as ready for review September 4, 2025 09:07
@mj12albert mj12albert added the breaking change Introduces changes that are not backward compatible. label Sep 4, 2025
@mj12albert mj12albert force-pushed the fix/slider-hidden-input branch 4 times, most recently from bc6b16f to 8946100 Compare September 8, 2025 09:20
@mj12albert mj12albert force-pushed the fix/slider-hidden-input branch from 8946100 to 20b7d55 Compare September 8, 2025 09:47
@oliviertassinari oliviertassinari added type: bug It doesn't behave as expected. accessibility a11y labels Sep 8, 2025
LukasTy
LukasTy approved these changes Sep 8, 2025
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👌
Nice direction towards more simplicity and clarity. 👍

@mj12albert mj12albert merged commit 351a2be into mui:master Sep 9, 2025
19 checks passed
@mj12albert mj12albert deleted the fix/slider-hidden-input branch September 9, 2025 03:57
atomiks pushed a commit to atomiks/base-ui that referenced this pull request Sep 10, 2025
@mj12albert @atomiks
[slider] Remove redundant hidden inputs (mui#2631)
54b1071
@oliviertassinari oliviertassinari mentioned this pull request Sep 18, 2025
Open
@brijeshb42 brijeshb42 mentioned this pull request Sep 24, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@LukasTy LukasTy LukasTy approved these changes

@atomiks atomiks atomiks approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

Assignees

No one assigned

Labels

accessibility a11y breaking change Introduces changes that are not backward compatible. component: slider Changes related to the slider component. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mj12albert @mui-bot @oliviertassinari @LukasTy @atomiks