Skip to content

[code-infra] Migrate build to tsdown #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[code-infra] Migrate build to tsdown #2582

wants to merge 1 commit into from

Conversation

@brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Aug 26, 2025

@brijeshb42 brijeshb42 added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Aug 26, 2025
@mui-bot
Copy link

mui-bot commented Aug 26, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react 🔺+4.47KB(+1.43%) 🔺+2.1KB(+2.11%)

Details of bundle changes

Generated by 🚫 dangerJS against f4ea592

@netlify
Copy link

netlify bot commented Aug 26, 2025

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 7382d67
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/68ad97b3ca7da70008ec6cf0
😎 Deploy Preview https://deploy-preview-2582--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 26, 2025 •
edited
Loading

vite-css-base-ui-example

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@2582

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@2582

commit: ee7077c

@netlify
Copy link

netlify bot commented Aug 26, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit ee7077c
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/68dd0d3699d4e00008d6fece
😎 Deploy Preview https://deploy-preview-2582--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 26, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 27, 2025
@brijeshb42 brijeshb42 mentioned this pull request Aug 27, 2025
Closed
@brijeshb42 brijeshb42 force-pushed the build-tsdown branch 5 times, most recently from 8099b74 to ef27b5a Compare August 28, 2025 06:06
@oliviertassinari oliviertassinari changed the title [infra] Migrate build to tsdown [code-infra] Migrate build to tsdown Aug 29, 2025
oliviertassinari
oliviertassinari reviewed Aug 29, 2025
View reviewed changes
docs/src/app/(public)/(content)/react/components/separator/demos/hero/tailwind/index.tsx
@@ -1,4 +1,3 @@
import * as React from 'react';
Copy link
Member

@oliviertassinari oliviertassinari Aug 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mui/mui-public#574, it feels like we should do this outside of the context of changing the bundler. One is DX for developers using the library, the other is DX for our maintainers, so once we exit the draft phase, two PRs?

Copy link
Contributor Author

@brijeshb42 brijeshb42 Aug 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be the final PR where it'll be just about the bundler migration.
This is just me testing what it requires to make the bundler work which'll then be moved to mui-public PR (all the common bits).

@brijeshb42 brijeshb42 mentioned this pull request Sep 1, 2025
Draft
@brijeshb42 brijeshb42 force-pushed the build-tsdown branch 2 times, most recently from f757c2a to 53802e5 Compare September 1, 2025 12:34
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 1, 2025
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Sep 1, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 29, 2025
@mui-bot
Copy link

mui-bot commented Sep 29, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react 🔺+5.17KB(+1.41%) 🔺+2.08KB(+1.79%)

Details of bundle changes

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 29, 2025
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@atomiks atomiks Awaiting requested review from atomiks atomiks will be requested when the pull request is marked ready for review atomiks is a code owner

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite will be requested when the pull request is marked ready for review colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak will be requested when the pull request is marked ready for review michaldudak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

PR: out-of-date The pull request has merge conflicts and can't be merged. scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brijeshb42 @mui-bot @oliviertassinari