Skip to content

[infra] Use CI action from mui-public #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 24, 2025
Merged

[infra] Use CI action from mui-public #2258

merged 3 commits into from
Jul 24, 2025

Conversation

@brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Jul 4, 2025

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 4, 2025 •
edited
Loading

vite-css-base-ui-example

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@2258

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@2258

commit: 133578f

@mui-bot
Copy link

mui-bot commented Jul 4, 2025 •
edited
Loading

Bundle size report

Bundle Parsed Size Gzip Size
@base-ui-components/react 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 133578f

@netlify
Copy link

netlify bot commented Jul 4, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 133578f
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/687fb63aaa5edf0008b32444
😎 Deploy Preview https://deploy-preview-2258--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@brijeshb42 brijeshb42 mentioned this pull request Jul 4, 2025
Merged
@brijeshb42 brijeshb42 added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Jul 4, 2025
@brijeshb42 brijeshb42 added scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). and removed scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). labels Jul 4, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jul 7, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jul 18, 2025
@brijeshb42 brijeshb42 changed the title [code-infra] Inherit label check gh action from infra repo [infra] Use CI action from mui-public Jul 18, 2025
@brijeshb42 brijeshb42 marked this pull request as ready for review July 18, 2025 11:12
@brijeshb42 brijeshb42 requested a review from a team July 18, 2025 11:14
michaldudak
michaldudak reviewed Jul 21, 2025
View reviewed changes
.github/workflows/ci.yml Outdated
permissions: {}

jobs:
continuous-releases:
Copy link
Member

@michaldudak michaldudak Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually builds the project for the second time. The original solution reused the build done previously. Also, from what I can see, the shared action has the --comment=off flag. We believe these comments are useful and would like to keep them (the deployment info can be included in Danger's or other comment, but it should be somewhere).

Copy link
Member

@Janpot Janpot Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, perhaps it would work better as a composite action with just the publish command and a comment input? I'm also fine keeping it as is if the composite action would rely on code-infra implicitly installed.

Copy link
Contributor Author

@brijeshb42 brijeshb42 Jul 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had initially added arguments for pre-build and post-build commands to run in which case for this repo, we would provide post-build: "pnpm validatedeclarations" but then went against it to keep things simple.
Currently, both material-ui and mui-x function similarly to what is in this PR but maybe both can be revisited to reuse same logic.

@brijeshb42 brijeshb42 mentioned this pull request Jul 22, 2025
Merged
@brijeshb42 brijeshb42 force-pushed the gh-actions branch 7 times, most recently from 4981c0e to a8cca55 Compare July 22, 2025 12:41
@brijeshb42 brijeshb42 force-pushed the gh-actions branch 2 times, most recently from 648ae6b to eea36c9 Compare July 22, 2025 15:27
@brijeshb42 brijeshb42 requested a review from michaldudak July 22, 2025 15:27
@brijeshb42
Copy link
Contributor Author

brijeshb42 commented Jul 24, 2025

@michaldudak review please.

michaldudak
michaldudak approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@brijeshb42 brijeshb42 merged commit 246388c into mui:master Jul 24, 2025
20 checks passed
@brijeshb42 brijeshb42 deleted the gh-actions branch July 24, 2025 12:14
@michaldudak michaldudak mentioned this pull request Jul 30, 2025
Closed
atomiks pushed a commit to atomiks/base-ui that referenced this pull request Sep 10, 2025
@brijeshb42 @atomiks
[infra] Use CI action from mui-public (mui#2258)
471288a 
Co-authored-by: Brijesh Bittu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Janpot Janpot Janpot approved these changes

@michaldudak michaldudak michaldudak approved these changes

@atomiks atomiks Awaiting requested review from atomiks atomiks is a code owner

Assignees

No one assigned

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brijeshb42 @mui-bot @Janpot @michaldudak